chore: update README.md #2441
Merged
chore: update README.md #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: documentation
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mkurapov
reviewed
Feb 22, 2024
README.md
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| ## What is Rafiki? | |||
|
|
|||
| Rafiki is open source software that allows an [Account Servicing Entity](https://rafiki.dev/concepts/account-servicing-entity/) to enable [Interledger](https://rafiki.dev/concepts/interledger-protocol/overview/) functionality on its users' accounts. | |||
| Rafiki is open source software that provides a more efficient method for an [Account Servicing Entity](https://rafiki.dev/concepts/account-servicing-entity/) to enable Interledger functionality on its users' accounts. | |||
There was a problem hiding this comment.
Suggested change
| Rafiki is open source software that provides a more efficient method for an [Account Servicing Entity](https://rafiki.dev/concepts/account-servicing-entity/) to enable Interledger functionality on its users' accounts. | |
| Rafiki is open source software that provides an efficient solution for an [Account Servicing Entity](https://rafiki.dev/concepts/account-servicing-entity/) to enable Interledger functionality on its users' accounts. |
nit-picky, but "a more" implies some sort of comparison between an alternative which we don't talk about
(we can also make this a slack discussion)
There was a problem hiding this comment.
Should we also update the landing page?
There was a problem hiding this comment.
good point. both of them. have made the changes in the next commit (also landing page)
github-actions
bot
added
the
pkg: documentation
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| ## What is Rafiki? | |||
|
|
|||
| Rafiki is open source software that allows an [Account Servicing Entity](https://rafiki.dev/concepts/account-servicing-entity/) to enable [Interledger](https://rafiki.dev/concepts/interledger-protocol/overview/) functionality on its users' accounts. | |||
| Rafiki is open source software that provides an efficient solution for an [Account Servicing Entity](https://rafiki.dev/concepts/account-servicing-entity/) to enable Interledger functionality on its users' accounts. | |||
There was a problem hiding this comment.
Nit-picky, but Account Servicing Entity should be in lowercase.
There was a problem hiding this comment.
I think we need a convention here, I would have argued "Account Servicing Entity" is always capitalized.
melissahenderson
approved these changes
Feb 22, 2024
AlexLakatos
approved these changes
Feb 22, 2024
mkurapov
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request